Add implementation specific attributes#447
Closed
collinoc wants to merge 1 commit intoapache:mainfrom
Closed
Conversation
tustvold
reviewed
Aug 6, 2025
Contributor
tustvold
left a comment
tustvold
left a comment
There was a problem hiding this comment.
Whilst I can appreciate the flexibility this would offer, I am somewhat concerned about the potentially hard to reason about interactions with other attributes... In particular if I specify Attribute::Other("meta-") the outcome will end up implementation defined based on whether ${IMPL_DEFINED_ATTR_HEADER_PREFIX}-meta- happens to map to Attribute::Metadata.
Similarly this somewhat breaks the design principal that attributes should roundrip or be rejected...
I wonder if we might instead just add support for the attributes you wish to support, i.e. lock mode and storage class?
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #446.
Rationale for this change
Currently there seems to be no support for applying implementation specific attributes within this API. For example with a
aws_store.put_opts(...)call, there would be no way to specify ax-amz-object-lock-modeattribute, or applyingx-goog-storage-classfor a GCP put operation. This adds support for such use cases.What changes are included in this PR?
Expands the
Attributeenum to include aOthervariant that will add headers with implementation specific prefixes (x-amz-for AWS, etc.)Are there any user-facing changes?
Yes, documentation was updated where I thought needed. Let me know if more is needed.
These changes should be backwards compatible.